fix: don't memoise configs, and allow external modules to call mdc:configSources#471
Merged
fix: don't memoise configs, and allow external modules to call mdc:configSources#471
mdc:configSources#471Conversation
7 tasks
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have an issue with external modules trying to push to config sources. Because Nuxt Content synchronously gets the config sources by listening and then uses them, it's impossible for modules registered after Nuxt Content to extend in this instance.
In a way, the way Nuxt content uses the hook is conflicting/confusing because Nuxt content is trying to consume the config sources, whereas in the MDC module, it is exposed as way of modules to extend config sources.
I'm not sure this is the right solution, but this approach is paired with nuxt/content#3736, and is intended to enable an external module (e.g. Nuxt content) to call the hook instead of just listening to it as well as a way of getting the configs.