Closed
Conversation
Marc-Antoine-Soucy
approved these changes
Mar 31, 2025
| Add a quick description of your changes. | ||
|
|
||
| Impact on version: | ||
| Please check the impact of your changes on the version. This should align with the changes made to the changelog file. |
Contributor
There was a problem hiding this comment.
I'm not seeing any changes in the changelog file, does this project have one? Should breaking_changes.md be the one we should check instead?
Author
There was a problem hiding this comment.
Well some packages have no changelogs and breaking change i thought about it but since it's not a breaking change I thought it wouldnt make much sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
Proposed Changes
Description
Updating the contributing documentation
Impact on version
buildfolder was changed..githubfolder was changed.PR Checklist
README.mdis up to date.Other information
Internal Issue (If applicable):