Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the BiometryService library from .NET 7 to .NET 10 and removes support for legacy platforms (Xamarin Android, Xamarin iOS, and UWP). This is a breaking change that modernizes the codebase and aligns with current .NET ecosystem standards.
Changes:
- Updated target frameworks from net7.0 to net10.0 across all projects
- Removed support for Xamarin Android, Xamarin iOS, and UWP platforms
- Updated package dependencies to versions compatible with .NET 10
- Removed legacy Xamarin sample projects (iOS, Android, UWP)
- Updated C# language version from 11.0 to 14.0
Reviewed changes
Copilot reviewed 34 out of 53 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/BiometryService/BiometryService.csproj | Updated to .NET 10 with modern SDK and removed legacy Xamarin/UWP targets |
| src/BiometryService/BiometryService.UWP.cs | Deleted - UWP implementation removed |
| src/BiometryService.Abstractions/BiometryService.Abstractions.csproj | Updated language version and package references |
| samples/BiometryService.SampleApp.Uno.Mobile/BiometryService.SampleApp.Uno.Mobile.csproj | Updated to .NET 10 with modern Uno platform packages |
| samples/BiometryService.SampleApp.Uno.WinUI/BiometryService.SampleApp.Uno.WinUI.csproj | Updated target framework to .NET 10 Windows |
| samples/BiometryService.SampleApp.Uno.Shared/App.xaml.cs | Simplified application initialization by removing legacy code |
| samples/BiometryService.SampleApp.Uno.Shared/MainPage.xaml.cs | Removed logger factory parameters from BiometryService constructors |
| samples/BiometryService.SampleApp.Uno.iOS/* | Deleted - legacy Xamarin iOS project removed |
| samples/BiometryService.SampleApp.Uno.Droid/* | Deleted - legacy Xamarin Android project removed |
| samples/BiometryService.SampleApp.Uno.UWP/* | Deleted - UWP project removed |
| BiometryService.sln | Removed references to deleted legacy projects |
| build/azure-pipelines.yml | Updated to Windows 2025 agent image |
| Directory.Build.targets | Deleted - SourceLink workaround no longer needed |
| BREAKING_CHANGES.md | Documented breaking changes for version 3.0.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
86235ae to
923e9cf
Compare
Soap-141
approved these changes
Jan 20, 2026
6e828e7 to
f587d13
Compare
lesterbotello
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
Proposed Changes
Description
Updated app to .NET 10, and dropped support for xamarin android, xamarin iOS, and UWP targets.
Impact on version
buildfolder was changed..githubfolder was changed.PR Checklist
README.mdis up to date.Other information
Internal Issue (If applicable):