fix(jump): jump sometimes highlights after jumping has stopped#2319
Open
abeldekat wants to merge 1 commit intonvim-mini:mainfrom
Open
fix(jump): jump sometimes highlights after jumping has stopped#2319abeldekat wants to merge 1 commit intonvim-mini:mainfrom
abeldekat wants to merge 1 commit intonvim-mini:mainfrom
Conversation
Details: - As a side-effect of the jump, a function is scheduled that will trigger a `BufLeave` event - After the jump, a function is scheduled immediately that will run `H.highlight`(0 delay.highlight) On `BufLeave`, `MiniJump.stop_jumping` is called. That will stop `H.timers.highlight`. However, the timer already scheduled the function. Thus, `H.highlight` runs and applies the highlighting, although `state.jumping` is false. This PR adds an extra early return to `H.highlight` Resolve nvim-mini#2318
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
As a side-effect of the jump, a function is scheduled that will trigger a
BufLeaveeventAfter the jump, a function is scheduled immediately that will run
H.highlight(0 delay.highlight)On
BufLeave,MiniJump.stop_jumpingis called.That will stop
H.timers.highlight. However, the timer already scheduled the function.Thus,
H.highlightruns and applies the highlighting, althoughstate.jumpingis false.This PR adds an extra early return to
H.highlightResolve #2318