Skip to content

Update file picker title#168

Open
ayushmanchhabra wants to merge 1 commit intonwjs:mainfrom
ayushmanchhabra:dev-8336
Open

Update file picker title#168
ayushmanchhabra wants to merge 1 commit intonwjs:mainfrom
ayushmanchhabra:dev-8336

Conversation

@ayushmanchhabra
Copy link
Copy Markdown
Contributor

@ayushmanchhabra ayushmanchhabra commented Mar 19, 2026

@ayushmanchhabra ayushmanchhabra changed the title Fall back to platform default Fall back to platform default when file picker title is empty string Mar 19, 2026
@ayushmanchhabra ayushmanchhabra changed the title Fall back to platform default when file picker title is empty string Update file picker title to Save As Mar 24, 2026
@ayushmanchhabra
Copy link
Copy Markdown
Contributor Author

ayushmanchhabra commented Mar 24, 2026

@GnorTech let me know if you want me to make the change in the file storing all the constants instead:
https://github.com/nwjs/chromium.src/blob/ad4cf560efed73a4bf0593bf6641ba1fc47e5b4c/chrome/app/generated_resources.grd#L17927

A third, but longer, option would be to have a custom generated_resources.grd which overrides certain values in Chromium.

Comment thread chrome/browser/file_system_access/chrome_file_system_access_permission_context.cc Outdated
@ayushmanchhabra ayushmanchhabra changed the title Update file picker title to Save As Add custom generated_resources.grd Apr 8, 2026
Comment thread chrome/browser/file_system_access/chrome_file_system_access_permission_context.cc Outdated
@ayushmanchhabra ayushmanchhabra marked this pull request as draft April 14, 2026 03:52
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review April 18, 2026 06:05
@ayushmanchhabra ayushmanchhabra changed the title Add custom generated_resources.grd Update file picker title Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scary window title when using window.showSaveFilePicker()

2 participants