Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Last cycle, some people ended up with more than one pairing.
Cause:
The interval was set to 0.2 minutes, meaning that Dinubot ran every 12 seconds. When it was time to create new pairings, Dinubot would begin pairing, then start another cycle before the first call was finished leading to corrupted data and multiple pairings.
This wasn't an issue previously because often the pairing would finish under 12 seconds and the next cycle would be skipped. But, because of the new lastPairings functionality, the algorithm took longer to find valid pairings and started a new cycle before the first finished.
Fix:
Additional notes:
Removed initial + test calls at the bottom