added token storing in $localStorage#109
Open
MikhailRoot wants to merge 3 commits intooauthjs:masterfrom
Open
Conversation
cookie are still used, it adds $localStorage support for token. it's usefull for hybrid mobile development.
MikhailRoot
changed the title
added token removal from localStorage as well. added ngStorage to karma conf.
have to disable unhandled rejections of promises while testing.
|
👍 Can we see this get merged? |
Member
|
The support for @MikhailRoot if you want to implement what was proposed there, I'll gladly merge it. |
piwel
approved these changes
May 22, 2017
piwel
left a comment
piwel
left a comment
There was a problem hiding this comment.
The documentation shall also be changed to import the ngStorage script.
ruipenso
requested changes
Nov 23, 2017
Member
ruipenso
left a comment
ruipenso
left a comment
There was a problem hiding this comment.
The use of localStorage should be an option with fallback if not supported.
|
Is there an update on this ? I would need this feature to be able to use this package on a cordova & electron project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it's unpossible to have cookies in cordova that's why localStorage used. Cookies are still used, it adds $localStorage support for token. So you can use methods like OAuth.isAuthenticated() same as with cookies but with localStorage transparently.