Add option to send client credentials (client_id and client_secret) in the header#122
Open
smoreau wants to merge 6 commits intooauthjs:masterfrom
Open
Add option to send client credentials (client_id and client_secret) in the header#122smoreau wants to merge 6 commits intooauthjs:masterfrom
smoreau wants to merge 6 commits intooauthjs:masterfrom
Conversation
ruipenso
requested changes
Nov 23, 2017
Member
ruipenso
left a comment
ruipenso
left a comment
There was a problem hiding this comment.
You just included the dist files... Where is the actual source code?
And, please remove the dist files - it will be included on the release.
…ecret) in the header" This reverts commit 1d8f881.
Author
|
It should be fine now. |
Author
|
Any news about this pull request? |
Author
|
I fixed all the JSHint warnings. This pull request is ready for your review. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RFC 6749 about OAuth 2.0 (https://tools.ietf.org/html/rfc6749#section-2.3.1) mentions the following:
"Including the client credentials in the request-body using the two
parameters is NOT RECOMMENDED and SHOULD be limited to clients unable
to directly utilize the HTTP Basic authentication scheme (or other
password-based HTTP authentication schemes). The parameters can only
be transmitted in the request-body and MUST NOT be included in the
request URI."
In order to be conform with this RFC, this pull request proposes to add an option "clientCredentials" which will send the client_id and client_secret in the Authorization header when the value is equal to "header".