Conversation
There was a problem hiding this comment.
Pull request overview
Updates outgoing email content and headers to better reflect a multi-person “Prüfungsplanung” team rather than a single planner.
Changes:
- Adjusts many mail templates from singular (“ich/mir”) to plural (“wir/uns”) and updates the FK07 signature wording.
- Tweaks various informational texts in room/invigilation/NTA/exam emails for the new voice.
- Updates
sendMailto generate a planner-specificReply-Tonoreply alias via plus-addressing.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| plexams/tmpl/publishedEmailRoomsHTML.tmpl | Switch wording to plural and update FK07 signature in rooms publication HTML mail |
| plexams/tmpl/publishedEmailRooms.tmpl | Switch wording to plural and update FK07 signature in rooms publication text mail |
| plexams/tmpl/publishedEmailInvigilationsHTML.tmpl | Switch wording to plural and update FK07 signature in invigilations publication HTML mail |
| plexams/tmpl/publishedEmailInvigilations.tmpl | Switch wording to plural and update FK07 signature in invigilations publication text mail |
| plexams/tmpl/publishedEmailExamsHTML.tmpl | Update FK07 signature wording in exams publication HTML mail |
| plexams/tmpl/publishedEmailExams.tmpl | Update FK07 signature wording in exams publication text mail |
| plexams/tmpl/preparedEmailHTML.tmpl | Switch prepared-notification wording to plural and update FK07 signature (HTML) |
| plexams/tmpl/preparedEmail.tmpl | Switch prepared-notification wording to plural and update FK07 signature (text) |
| plexams/tmpl/newNTAEmailHTML.tmpl | Switch new-NTA notification wording to plural (HTML) |
| plexams/tmpl/newNTAEmail.tmpl | Switch new-NTA notification wording to plural (text) |
| plexams/tmpl/invigilationEmailHTML.tmpl | Switch invigilation constraints mail wording to plural and update FK07 signature (HTML) |
| plexams/tmpl/invigilationEmail.tmpl | Switch invigilation constraints mail wording to plural and update FK07 signature (text) |
| plexams/tmpl/handicapEmailRoomAloneHTML.tmpl | Switch NTA room-alone student mail wording to plural (HTML) |
| plexams/tmpl/handicapEmailRoomAlone.tmpl | Switch NTA room-alone student mail wording to plural (text) |
| plexams/tmpl/handicapEmailPlannedHTML.tmpl | Switch planned NTA student mail wording to plural (HTML) |
| plexams/tmpl/handicapEmailPlanned.tmpl | Switch planned NTA student mail wording to plural (text) |
| plexams/tmpl/handicapEmailHTML.tmpl | Switch teacher handicap overview mail wording to plural (HTML) |
| plexams/tmpl/handicapEmail.tmpl | Switch teacher handicap overview mail wording to plural (text) |
| plexams/tmpl/generatedExamEmailHTML.tmpl | Switch generated-exam mail wording to plural (HTML) |
| plexams/tmpl/generatedExamEmail.tmpl | Switch generated-exam mail wording to plural (text) |
| plexams/tmpl/exahmEmailHTML.tmpl | Update FK07 signature wording in EXaHM mail (HTML) |
| plexams/tmpl/exahmEmail.tmpl | Update FK07 signature wording in EXaHM mail (text) |
| plexams/tmpl/draftEmailZPAHTML.tmpl | Switch draft-plan mail wording to plural and update FK07 signature (HTML) |
| plexams/tmpl/draftEmailZPA.tmpl | Switch draft-plan mail wording to plural and update FK07 signature (text) |
| plexams/tmpl/draftEmailFSHTML.tmpl | Switch draft-plan-to-FS mail wording to plural and update FK07 signature (HTML) |
| plexams/tmpl/draftEmailFS.tmpl | Switch draft-plan-to-FS mail wording to plural and update FK07 signature (text) |
| plexams/tmpl/coverPageEmailHTML.tmpl | Update FK07 signature wording in cover page mail (HTML) |
| plexams/tmpl/coverPageEmail.tmpl | Update FK07 signature wording in cover page mail (text) |
| plexams/tmpl/constraintsEmailHTML.tmpl | Switch constraints request wording to plural and update FK07 signature (HTML) |
| plexams/tmpl/constraintsEmail.tmpl | Switch constraints request wording to plural and update FK07 signature (text) |
| plexams/email.go | Generate noreply Reply-To address based on configured planner email via plus-addressing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {{ if not .HasStudentRegs }} | ||
| <p><b>Für Ihre Prüfung <b>{{ .Exam.ZpaExam.AnCode }}. {{ .Exam.ZpaExam.Module }}</b> liegen überhaupt keine Anmeldungen vor, daher werde ich sie nicht | ||
| planen.</b> Falls die Prüfung dennoch eingeplant werden soll, teilen Sie mir das bitte unmittelbar | ||
| <p><b>Für Ihre Prüfung <b>{{ .Exam.ZpaExam.AnCode }}. {{ .Exam.ZpaExam.Module }}</b> liegen überhaupt keine Anmeldungen vor, daher werden wir sie nicht |
There was a problem hiding this comment.
Das HTML hat hier verschachtelte -Tags („… … …“), was ungültiges Markup ist und je nach Client zu unerwarteter Formatierung führen kann. Bitte die Tags so anpassen, dass die Hervorhebung korrekt geöffnet/geschlossen wird (z.B. nur ein -Bereich oder korrekt geschachtelte Struktur).
Suggested change
| <p><b>Für Ihre Prüfung <b>{{ .Exam.ZpaExam.AnCode }}. {{ .Exam.ZpaExam.Module }}</b> liegen überhaupt keine Anmeldungen vor, daher werden wir sie nicht | |
| <p><b>Für Ihre Prüfung {{ .Exam.ZpaExam.AnCode }}. {{ .Exam.ZpaExam.Module }} liegen überhaupt keine Anmeldungen vor, daher werden wir sie nicht |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.