Skip to content

stack invalid values as NaN #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fil wants to merge 1 commit into
base: main
Choose a base branch
from
Open

stack invalid values as NaN #2390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transforms/stack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ function stack(x, y = one, kx, ky, {offset, order, reverse}, options) {
const y = Y[i];
if (y < 0) yn = Y2[i] = (Y1[i] = yn) + y;
else if (y > 0) yp = Y2[i] = (Y1[i] = yp) + y;
else Y2[i] = Y1[i] = yp; // NaN or zero
else Y2[i] = Y1[i] = y === 0 ? yp : NaN;
}
}
facetstacks.push(stacks);
Expand Down
30 changes: 15 additions & 15 deletions test/output/availability.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
42 changes: 21 additions & 21 deletions test/output/downloads.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions test/output/integerIntervalArea.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@
<text transform="translate(620,370)">x →</text>
</g>
<g aria-label="area" fill-opacity="0.7" stroke-width="2" stroke-linejoin="round" stroke-linecap="round">
<path fill="#4269d0" stroke="#4269d0" d="M40,260.625L330,216.875L620,370L620,370L330,370L40,370Z"></path>
<path fill="#efb118" stroke="#efb118" d="M40,260.625L330,20L620,282.5L620,370L330,216.875L40,260.625Z"></path>
<path fill="#4269d0" stroke="#4269d0" d="M40,260.625L330,216.875L330,370L40,370Z"></path>
<path fill="#efb118" stroke="#efb118" d="M330,20L620,282.5L620,370L330,216.875Z"></path>
</g>
<g aria-label="tip" fill="var(--plot-background)" stroke="currentColor" pointer-events="none" text-anchor="start" transform="translate(0.5,0.5)"></g>
</svg>
Expand Down
46 changes: 23 additions & 23 deletions test/output/integerIntervalAreaZ.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,48 +52,48 @@
</style>
<g aria-label="y-axis tick" aria-hidden="true" fill="none" stroke="currentColor" transform="translate(0,0.5)">
<path transform="translate(40,370)" d="M0,0L-6,0"></path>
<path transform="translate(40,328.8235294117647)" d="M0,0L-6,0"></path>
<path transform="translate(40,287.6470588235294)" d="M0,0L-6,0"></path>
<path transform="translate(40,246.4705882352941)" d="M0,0L-6,0"></path>
<path transform="translate(40,205.2941176470588)" d="M0,0L-6,0"></path>
<path transform="translate(40,164.11764705882354)" d="M0,0L-6,0"></path>
<path transform="translate(40,122.94117647058823)" d="M0,0L-6,0"></path>
<path transform="translate(40,81.76470588235296)" d="M0,0L-6,0"></path>
<path transform="translate(40,40.58823529411765)" d="M0,0L-6,0"></path>
<path transform="translate(40,328.824)" d="M0,0L-6,0"></path>
<path transform="translate(40,287.647)" d="M0,0L-6,0"></path>
<path transform="translate(40,246.471)" d="M0,0L-6,0"></path>
<path transform="translate(40,205.294)" d="M0,0L-6,0"></path>
<path transform="translate(40,164.118)" d="M0,0L-6,0"></path>
<path transform="translate(40,122.941)" d="M0,0L-6,0"></path>
<path transform="translate(40,81.765)" d="M0,0L-6,0"></path>
<path transform="translate(40,40.588)" d="M0,0L-6,0"></path>
</g>
<g aria-label="y-axis tick label" text-anchor="end" font-variant="tabular-nums" transform="translate(-8.5,0.5)">
<text y="0.32em" transform="translate(40,370)">0</text>
<text y="0.32em" transform="translate(40,328.8235294117647)">2</text>
<text y="0.32em" transform="translate(40,287.6470588235294)">4</text>
<text y="0.32em" transform="translate(40,246.4705882352941)">6</text>
<text y="0.32em" transform="translate(40,205.2941176470588)">8</text>
<text y="0.32em" transform="translate(40,164.11764705882354)">10</text>
<text y="0.32em" transform="translate(40,122.94117647058823)">12</text>
<text y="0.32em" transform="translate(40,81.76470588235296)">14</text>
<text y="0.32em" transform="translate(40,40.58823529411765)">16</text>
<text y="0.32em" transform="translate(40,328.824)">2</text>
<text y="0.32em" transform="translate(40,287.647)">4</text>
<text y="0.32em" transform="translate(40,246.471)">6</text>
<text y="0.32em" transform="translate(40,205.294)">8</text>
<text y="0.32em" transform="translate(40,164.118)">10</text>
<text y="0.32em" transform="translate(40,122.941)">12</text>
<text y="0.32em" transform="translate(40,81.765)">14</text>
<text y="0.32em" transform="translate(40,40.588)">16</text>
</g>
<g aria-label="y-axis label" text-anchor="start" transform="translate(-36.5,-16.5)">
<text y="0.71em" transform="translate(40,20)">↑ y</text>
</g>
<g aria-label="x-axis tick" aria-hidden="true" fill="none" stroke="currentColor" transform="translate(0.5,0)">
<path transform="translate(40,370)" d="M0,0L0,6"></path>
<path transform="translate(233.33333333333331,370)" d="M0,0L0,6"></path>
<path transform="translate(426.66666666666663,370)" d="M0,0L0,6"></path>
<path transform="translate(233.333,370)" d="M0,0L0,6"></path>
<path transform="translate(426.667,370)" d="M0,0L0,6"></path>
<path transform="translate(620,370)" d="M0,0L0,6"></path>
</g>
<g aria-label="x-axis tick label" font-variant="tabular-nums" transform="translate(0.5,9.5)">
<text y="0.71em" transform="translate(40,370)">0.0</text>
<text y="0.71em" transform="translate(233.33333333333331,370)">1.0</text>
<text y="0.71em" transform="translate(426.66666666666663,370)">2.0</text>
<text y="0.71em" transform="translate(233.333,370)">1.0</text>
<text y="0.71em" transform="translate(426.667,370)">2.0</text>
<text y="0.71em" transform="translate(620,370)">3.0</text>
</g>
<g aria-label="x-axis label" text-anchor="end" transform="translate(17.5,27.5)">
<text transform="translate(620,370)">x →</text>
</g>
<g aria-label="area" fill-opacity="0.7" stroke-width="2" stroke-linejoin="round" stroke-linecap="round">
<path fill="#b2df8a" stroke="#a6cee3" d="M40,267.059L233.333,225.882L426.667,370L620,370L620,370L426.667,370L233.333,370L40,370Z"></path>
<path fill="#33a02c" stroke="#a6cee3" d="M40,267.059L233.333,40.588L426.667,287.647L620,370L620,370L426.667,370L233.333,225.882L40,267.059Z"></path>
<path fill="#fb9a99" stroke="#1f78b4" d="M40,267.059L233.333,20L426.667,287.647L620,225.882L620,370L426.667,287.647L233.333,40.588L40,267.059Z"></path>
<path fill="#b2df8a" stroke="#a6cee3" d="M40,267.059L233.333,225.882L233.333,370L40,370Z"></path>
<path fill="#33a02c" stroke="#a6cee3" d="M233.333,40.588L426.667,287.647L426.667,370L233.333,225.882Z"></path>
<path fill="#fb9a99" stroke="#1f78b4" d="M233.333,20L233.333,40.588ZM620,225.882L620,370Z"></path>
</g>
<g aria-label="tip" fill="var(--plot-background)" stroke="currentColor" pointer-events="none" text-anchor="start" transform="translate(0.5,0.5)"></g>
</svg>
Expand Down
Loading
Loading