Conversation
jashan-lco
left a comment
jashan-lco
left a comment
There was a problem hiding this comment.
This all looks good, but we've been having issues with Poetry in Banzailand and I think a few projects have moved to uv. I'm wondering if that should be our new "default".
| boto3 = ">=1,<2" | ||
| requests = ">=2,<3" | ||
| python-dateutil = ">=2,<3" | ||
| astropy = "^7" |
There was a problem hiding this comment.
Does any of this actually break with astropy < 7? It would be easier if the constraint was >=6 and numpy was >= 1.24. Astropy has so many versions, restricting to 7 will severely limit backward compatibility.
There was a problem hiding this comment.
so If I make the astropy >6, numpy >1.24, then poetry fails on newer python since those pythons require astropy 7, numpy 2 and poetry solves for ALL pythons to be valid. I tried doing a matrix of astropy/numpy/python versions and poetry still failed. So I think its just a limitation of poetry, but maybe uv fixes that?
There was a problem hiding this comment.
Maybe it's not worth trying to support all the old numpys.
|
I am indeed migrating banzai over to using uv to manage pytorch dependencies better. |
|
Looks like we may need to remove older python versions from the tests action as well. |
I think I did this in the github action |
It's still waiting to run_tests back to py |
3 participants
Switch out setup.py for poetry and update dependencies. Once ocs_archive branch is merged, I will update this PR to point to its latest version 0.5.0 instead of the git branch.