Skip to content

feat: Workspace 1054#173

Open
SKairinos wants to merge 46 commits intomainfrom
workspace_1054
Open

feat: Workspace 1054#173
SKairinos wants to merge 46 commits intomainfrom
workspace_1054

Conversation

@SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Jan 26, 2026

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faucomte97 reviewed 17 files and all commit messages.
Reviewable status: 17 of 35 files reviewed, all discussions resolved.

@SKairinos SKairinos linked an issue Feb 3, 2026 that may be closed by this pull request
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faucomte97 reviewed 21 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos).


docs/client-side-encryption.md line 34 at r2 (raw file):

---

## 4. Encryption/Decryption Utilities

This title and the subsequent ones have numbers that need to be decremented (3 was skipped)


docs/client-side-encryption.md line 53 at r2 (raw file):

1. **Model-level:** Every `EncryptedModel` subclass must define a unique `associated_data` string. This scopes all encrypted fields within that model.
2. **Field-level:** Every `BaseEncryptedField` instance must be initialized with its own `associated_data` string, which must be unique within that model.

Replace the end of this with "which must be unique within that field"

@SKairinos SKairinos marked this pull request as ready for review February 9, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create the model mixin and properties for each model Update documentation

2 participants