Open
Conversation
faucomte97
reviewed
Feb 3, 2026
Contributor
faucomte97
left a comment
There was a problem hiding this comment.
@faucomte97 reviewed 17 files and all commit messages.
Reviewable status: 17 of 35 files reviewed, all discussions resolved.
faucomte97
reviewed
Feb 7, 2026
Contributor
faucomte97
left a comment
There was a problem hiding this comment.
@faucomte97 reviewed 21 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos).
docs/client-side-encryption.md line 34 at r2 (raw file):
--- ## 4. Encryption/Decryption Utilities
This title and the subsequent ones have numbers that need to be decremented (3 was skipped)
docs/client-side-encryption.md line 53 at r2 (raw file):
1. **Model-level:** Every `EncryptedModel` subclass must define a unique `associated_data` string. This scopes all encrypted fields within that model. 2. **Field-level:** Every `BaseEncryptedField` instance must be initialized with its own `associated_data` string, which must be unique within that model.
Replace the end of this with "which must be unique within that field"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is