Fix code review issues across contracts and transactions#266
Merged
joshuahannan merged 1 commit intomasterfrom Mar 19, 2026
Merged
Fix code review issues across contracts and transactions#266joshuahannan merged 1 commit intomasterfrom
joshuahannan merged 1 commit intomasterfrom
Conversation
- NonFungibleToken: fix typo "conficting", convert block comment to /// - MetadataViews: replace nil-check+force-unwrap with if-let in getNFTView, dictToTraits, and Edition.init; fix spacing in Media/ExternalURL/NFTCollectionData inits; convert Trait field comments to ///; rename addTrait parameter t → trait - ExampleNFT: remove dead variable uriValue; var → let for newNFT; replace force-unwrap on metadata["mintedTime"] with panic; replace unsafe as! cast with as? ?? panic in EVMBridgedMetadata case; simplify getSupportedNFTTypes to return a literal; add TODO comment on dummy EVM address; fix @return tag - NFTForwarding: fix incorrect "init" in changeRecipient error message - ViewResolver: convert // to /// doc comments - setup_account_from_nft_reference: fix double force-unwrap on NFTCollectionData, add idempotency guard, publish cap at collectionData.publicPath, add UnpublishCapability entitlement - mint_nft: improve pre-condition message to include actual array lengths Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mfbz
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/* ## */block comment to///doc commentsif letingetNFTView,dictToTraits, andEdition.init; fix missing spaces around=inMedia,ExternalURL, andNFTCollectionDatainits; convertTraitfield comments to///; renameaddTraitparametert→traituriValue;var newNFT→let newNFT; replace force-unwrap onmetadata["mintedTime"]with?? panic; replace unsafeas!cast withas? ?? panicinEVMBridgedMetadatacase; simplifygetSupportedNFTTypesto return a dict literal; add prominentTODOcomment on dummy EVM address; fix@{...}→@returnin doc comment"init"inchangeRecipientpre-condition error message//to///doc commentsNFTCollectionData; add idempotency guard (no panic on second call); publish cap atcollectionData.publicPathinstead of caller-supplied path; addUnpublishCapabilityentitlementprecondition message to include actual array lengthsTest plan
make cipasses (all 24 Cadence tests + Go tests)🤖 Generated with Claude Code