Skip to content

Add virtual destructor #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lauris71 merged 2 commits into from
Apr 13, 2026
Merged

Add virtual destructor #119

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e7b213
Add virtual destructor
metsma Apr 13, 2026
d9c6c82
Merge branch 'master' into log
lauris71 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions cdoc/Logger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,10 @@
*
*/

#ifndef __LOGGER_H__INCLUDED__
#define __LOGGER_H__INCLUDED__
#pragma once

#include <cdoc/Exports.h>
#include <cdoc/CDoc.h>

#include <string>

namespace libcdoc
{

Expand All @@ -33,6 +29,8 @@ namespace libcdoc
class CDOC_EXPORT Logger
{
public:
virtual ~Logger() noexcept = default;

/**
* @brief Logs given message with given severity, file name and line number.
*
Expand All @@ -55,7 +53,7 @@ class CDOC_EXPORT Logger
* to LEVEL_INFO (default), then LEVEL_FATAL, LEVEL_ERROR, LEVEL_WARNING and LEVEL_INFO
* messages are logged, but not LEVEL_DEBUG or LEVEL_TRACE messages.
*/
void setMinLogLevel(LogLevel level) noexcept { min_level = level; }
constexpr void setMinLogLevel(LogLevel level) noexcept { min_level = level; }

protected:
/**
Expand All @@ -79,5 +77,3 @@ class CDOC_EXPORT Logger
};

}

#endif
Loading