pekko: Improve PekkoRouteHolder#16390
Open
samwright wants to merge 12 commits intoopen-telemetry:mainfrom
Open
pekko: Improve PekkoRouteHolder#16390samwright wants to merge 12 commits intoopen-telemetry:mainfrom
samwright wants to merge 12 commits intoopen-telemetry:mainfrom
Conversation
- Give each Directive its own PekkoRouteHolder to avoid concurrent access. Only when there's a route match are the PekkoRouteHolders in that call stack combined. - Remove need for state queue - remove query params from tapir http.route, as required by otel convention - support Tapir's internal route concatenation feature
trask
reviewed
Apr 17, 2026
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
- Fix Nullable import - Add volatile to fields accessed in different threads - Move constructor to top of PekkoRouteHolder - Use '.flatMap(routeHolder -> Optional.ofNullable(routeHolder.route()))' to make clear that `routeHolder.route()` can return `null`.
trask
reviewed
Apr 19, 2026
Member
|
hey @samwright, fyi both of the above reviews from me were really from AI (based on proposal in #17889), sorry I thought I had mentioned that above, but apparently not |
- LinkedList -> ArrayList + ArrayDeque - no unnecessary onThrowable in advice
Contributor
Author
That's cool - I had already guessed :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NullPointerExceptionandArrayIndexOutOfBoundsExceptionwith pekko-http #15681. Only when there's a route match are the PekkoRouteHolders in that call stack combined.