Rename instrumentation module names from kebab-case to snake_case#16442
Closed
zeitlinger wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
Rename instrumentation module names from kebab-case to snake_case#16442zeitlinger wants to merge 2 commits intoopen-telemetry:mainfrom
zeitlinger wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Fixes open-telemetry#15745. Instrumentation names now use underscores instead of hyphens, which looks more natural in YAML declarative configuration files. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
zeitlinger
force-pushed
the
module-names-snake-case
branch
from
9d45dd6 to
6476d85
Compare
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
Since we don't test with declarative config this won't help. |
Member
Author
|
Closing for now - need to discuss if this is worth it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InstrumentationModuleconstructorsuper()string literals (298 files)akka-httpbecomeakka_http, making them valid YAML keys without quoting in declarative configurationFixes #15745.
Test plan
AgentDistributionConfig.isInstrumentationEnabled()already normalizes hyphens to underscores vianame.replace('-', '_')on line 128)