Restrict secrets to protected branches#16648
Merged
trask merged 1 commit intoopen-telemetry:mainfrom Mar 18, 2026
Merged
Conversation
Contributor
I think that the only branches we have besides these are the renovate ones. |
laurit
approved these changes
Mar 18, 2026
Member
Author
my main motivation is that the copilot coding agent branches won't have access |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically motivated by wanting to enable new feature https://github.blog/changelog/2026-03-13-optionally-skip-approval-for-copilot-coding-agent-actions-workflows/
Which will allow CI to run automatically on copilot coding agent PRs (instead of having to hit Approve every time which is annoying).
The only downside to this is that copilot PRs could add workflows that access secrets (of course this relies on us reviewing the PR before hitting Approve).
Restricting secrets to
mainandrelease/*branches, which are already protected and can only be updated via PR merge, addresses this concern.I have related IaC PR up: https://github.com/open-telemetry/admin/pull/595