Skip to content

Review fixes for google-http-client-1.19:javaagent#16660

Merged
laurit merged 1 commit intomainfrom
otelbot/code-review-google-http-client-1.19-javaagent
Mar 18, 2026
Merged

Review fixes for google-http-client-1.19:javaagent#16660
laurit merged 1 commit intomainfrom
otelbot/code-review-google-http-client-1.19-javaagent

Conversation

@otelbot
Copy link
Copy Markdown
Contributor

@otelbot otelbot Bot commented Mar 18, 2026

Automated code review of instrumentation/google-http-client-1.19/javaagent.

gpt-5.3-codex

Status File Category Note
Fixed build.gradle.kts:11 Build Added assertInverse.set(true) to muzzle pass block for inverse range validation.
Fixed build.gradle.kts:20 Build Moved collectMetadata system property to withType<Test>().configureEach so custom test tasks inherit it.
Fixed GoogleHttpRequestInstrumentation:41 Javaagent Removed redundant isMethod() from transform() method matchers.
Fixed HttpHeaderSetter:11 Style Replaced enum singleton TextMapSetter with class-based implementation and usage via new HttpHeaderSetter().
Fixed HttpHeaderSetter:15 Style Added upstream-contract @Nullable carrier parameter and null guard in TextMapSetter#set.
Fixed AbstractGoogleHttpClientTest:48 Testing Changed test base class to package-private visibility.

Totals: Fixed 6, Needs Manual Fix 0

claude-sonnet-4.6

No issues found.

Automated code review of instrumentation/google-http-client-1.19/javaagent.
@otelbot otelbot Bot requested a review from a team as a code owner March 18, 2026 04:03
@laurit laurit merged commit cd63d1c into main Mar 18, 2026
96 checks passed
@laurit laurit deleted the otelbot/code-review-google-http-client-1.19-javaagent branch March 18, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant