Clarify that SpanBuilder.setAttribute allows nulls#8072
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom Feb 13, 2026
Merged
Clarify that SpanBuilder.setAttribute allows nulls#8072jack-berg merged 1 commit intoopen-telemetry:mainfrom
jack-berg merged 1 commit intoopen-telemetry:mainfrom
Conversation
trask
force-pushed
the
set-attribute-null-value
branch
from
2fcc1b3 to
b38384c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8072 +/- ##
============================================
- Coverage 90.20% 90.19% -0.01%
- Complexity 7593 7594 +1
============================================
Files 841 841
Lines 22913 22913
Branches 2289 2289
============================================
- Hits 20668 20667 -1
- Misses 1529 1531 +2
+ Partials 716 715 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
reviewed
Feb 12, 2026
|
|
||
| @Override | ||
| public NoopSpanBuilder setAttribute(String key, String value) { | ||
| public NoopSpanBuilder setAttribute(String key, @Nullable String value) { |
Member
There was a problem hiding this comment.
How did you run into this in practice? Given that DefaultTracer is package private, I assume everyone is actually dealing with the public Tracer interface.
Maybe you're just trying to keep the annotations consistent across interfaces and implementations?
Member
Author
There was a problem hiding this comment.
I think nullaway gave me an error
jack-berg
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7271