Break sdk incubator dependency on autoconfigure#8242
Open
jack-berg wants to merge 4 commits intoopen-telemetry:mainfrom
Open
Break sdk incubator dependency on autoconfigure#8242jack-berg wants to merge 4 commits intoopen-telemetry:mainfrom
jack-berg wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8242 +/- ##
============================================
- Coverage 90.32% 90.30% -0.03%
+ Complexity 7654 7650 -4
============================================
Files 843 844 +1
Lines 23080 23076 -4
Branches 2312 2310 -2
============================================
- Hits 20848 20838 -10
- Misses 1516 1521 +5
- Partials 716 717 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…y-java into break-incubator-autoconfigure-dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #7292
Right now declarative config in the
opentelemetry-sdk-extension-incubatormodule depends on autoconfigure for a few key bits of functionality:otel.service.attributes, which is reused to handle.resource.attributes_listThese dependencies require autoconfigure to load file config via reflection in order to avoid a circular dependency. Ultimately, we want some sort of dedicated config module, with autoconfigure having a dependency on it. This requires we break the incubator -> autoconfigure dependency, which is what this PR does.
Changes:
otel.resource.attributesparsing logic to declarative config. This allows the code to be reused without having to move to a central public location likeopentelemetry-sdk-common, and without having to manually synchronize the content.