Fix falcon-instrumentation _handle_exception method to remove pylint disables#4207
Merged
xrmx merged 7 commits intoopen-telemetry:mainfrom Mar 2, 2026
Merged
Conversation
|
|
emdneto
reviewed
Feb 20, 2026
Member
emdneto
left a comment
emdneto
left a comment
There was a problem hiding this comment.
@srikaaviya lint still failing
emdneto
approved these changes
Feb 20, 2026
srikaaviya
added a commit
to srikaaviya/opentelemetry-python-contrib
that referenced
this pull request
Feb 21, 2026
tammy-baylis-swi
moved this from Easy to review / merge / close
to Approved PRs
in Python PR digest
xrmx
approved these changes
Feb 26, 2026
xrmx
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
_handle_exceptionmethod in the Falcon instrumentation had pylint warnings suppressed with inline disable comments (C0103,W0237,W1114) because a single method definition was trying to handle two different Falcon versions that havedifferent argument orders.
This change defines
_handle_exceptionconditionally based on the detected Falcon versionat import time:
_handle_exception(self, ex, req, resp, params)- matching the Falcon 1 base class signature_handle_exception(self, req, resp, ex, params)- matching the Falcon 2+ base class signatureSince each version now uses the correct parameter names in the correct order, all three
pylint warnings are resolved without needing any disable comments.
Fixes #4198
Test:
C0103,W0237, orW1114warnings