Fix dead benchmarks link in documentation#4238
Fix dead benchmarks link in documentation#4238rohansood10 wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
| Performance benchmarks for individual packages can be found within each package's directory | ||
| (e.g., ``propagator/opentelemetry-propagator-aws-xray/benchmarks/``). | ||
|
|
||
| To run benchmarks locally, install the package with its benchmark dependencies and use ``pytest --benchmark-only``. |
There was a problem hiding this comment.
Thanks for catching this!
To reduce duplication, I suggest pointing to ## Benchmarks in Contributing.md
Results are also available now at https://opentelemetry.io/docs/languages/python/benchmarks/
|
This is a docs-only fix (updating a dead link in the documentation). Could a maintainer add the "Skip Changelog" label? No functional code changes are included. |
The benchmarks page on GitHub Pages no longer exists. Update the documentation to point users to the in-repo benchmark directories instead. Fixes open-telemetry#4163 Signed-off-by: rohansood10 <rohansood10@users.noreply.github.com>
rohansood10
force-pushed
the
fix/4163-dead-benchmarks-link
branch
from
df4fa10 to
fab727d
Compare
|
Hi @tammy-baylis-swi, thanks for reviewing! This PR is ready to merge - it just fixes a dead link in the documentation. All checks have passed. |
Hi @rohansood10 , did you have a chance to make revisions based on my suggestion? |
2 participants
Fixes #4163
The benchmarks page at
https://open-telemetry.github.io/opentelemetry-python-contrib/benchmarks/index.htmlreturns a 404. The entire GitHub Pages site appears to be down.This updates
docs/performance/benchmarks.rstto point users to the in-repo benchmark directories instead of the dead external link.