Support enable_commenter for instrument_connection (version 2)#4267
Draft
tammy-baylis-swi wants to merge 16 commits intoopen-telemetry:mainfrom
Draft
Support enable_commenter for instrument_connection (version 2)#4267tammy-baylis-swi wants to merge 16 commits intoopen-telemetry:mainfrom
tammy-baylis-swi wants to merge 16 commits intoopen-telemetry:mainfrom
Conversation
14 tasks
…-commenter-instrument-connection
…-commenter-instrument-connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support
enable_commenterfor psycopg2/psycopginstrument_connectionfunctions.Fixes #3070
Depends on #4257 to fix
instrument_connectionin psycopg2 first.This replaces #3071
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e py312-test-instrumentation-psycopg2tox -e py312-test-instrumentation-psycopgPsycopg2Instrumentor.instrument_connectionPsycopgInstrumentor.instrument_connectionDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.