Open
Conversation
majanjua-amzn
force-pushed
the
always-record-sampler
branch
2 times, most recently
from
84e3e1a to
6bbf745
Compare
5 tasks
Contributor
|
We need to wait for the specs to be approved and released before merging this |
Contributor
Author
|
@xrmx spec is merged, ready for review! |
majanjua-amzn
force-pushed
the
always-record-sampler
branch
from
6bbf745 to
93a29f2
Compare
Contributor
Author
|
Hey folks, any update here? @xrmx perhaps? Also, seems the PR build is failing with something unrelated to my changes, perhaps needs to be rerun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new AlwaysRecordSampler as per:
This sampler behaves the same as it's root sampler, with the exception that it will replace any DROP decisions with an equivalent RECORD one, while maintaining the attributes and trace state from the decision created by the root sampler.
Also renamed the folder holding the tests for experimental sampling features from
composite_samplertosampling_experimental, as more than just the composite sampler is being tested in this folder, respecting the organization of the files in the src folder.Type of change
How Has This Been Tested?
Unit tests
Does This PR Require a Contrib Repo Change?
Checklist: