Fix incorrect AttributeError for invalid AnyValue types (#4821)#4876
Open
tejaspavanb wants to merge 3 commits intoopen-telemetry:mainfrom
Open
Fix incorrect AttributeError for invalid AnyValue types (#4821)#4876tejaspavanb wants to merge 3 commits intoopen-telemetry:mainfrom
tejaspavanb wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
xrmx
reviewed
Jan 12, 2026
Contributor
There was a problem hiding this comment.
Given that 3.9 is deprecated since november and since the report of the issue we've already changed the code to reduce greatly the time this code is called in practice if we really want to merge this, we need to add a comment with a TODO for go back to plain __name__ after we drop 3.9 support in May.
Author
|
Thanks for the clarification. I’ve added a TODO comment near the workaround noting that it should be removed and reverted once Python 3.9 support is dropped. Please let me know if the wording looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4821
Summary
On Python 3.9, passing an invalid
AnyValuetype could raise an unexpectedAttributeErrorwhile constructing the error message, due to certain
typingtypes missing a__name__attribute.
Motivation and Context
This change ensures that error messages are constructed safely by resolving type names
using a fallback mechanism. It restores the expected
TypeErrorbehavior without alteringexisting functionality. The fix follows the approach suggested in the issue discussion
and adds a regression test to cover this edge case.
Type of change
How Has This Been Tested?
Test details
python -m pytest opentelemetry-api/tests/attributesTypeErroris raised only when stringification of an invalid value failsDoes This PR Require a Contrib Repo Change?
Checklist