feat(trace): implement span start/end metrics

[anuraaga]

Description

I am helping to implement SDK internal metrics

https://opentelemetry.io/docs/specs/semconv/otel/sdk-metrics/

I have started with the most basic of them, started and ended spans. This sets up some test infrastructure as well and will be good to confirm before implementing more.

For reference, similar change in
Java: open-telemetry/opentelemetry-java#7895
JS: open-telemetry/opentelemetry-js#6213

/cc @xrmx to help with review

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Unit tests

Does This PR Require a Contrib Repo Change?

• Yes. - Link to PR:
• No.

Checklist:

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[anuraaga]

Hmm - this change may be hard since many contrib tests seem to verify metric count itself, not just the metrics from the instrumentation. Any ideas how to proceed?

[xrmx]

Hmm - this change may be hard since many contrib tests seem to verify metric count itself, not just the metrics from the instrumentation. Any ideas how to proceed?

Assuming most of the instrumentations are using TestBase from tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py maybe adding filtering to get_sorted_metrics will make updating the instrumentation easy. I think we also have some pytest based helpers but these should be local to the instrumentations.

UPDATE: I see also some are reading directly from a MetricReader so that should also require local filtering or move to TestBase

[anuraaga]

Thanks for the hint on TestBase @xrmx - it seems to fix a (very ;) ) few of the tests. I'll take the failures here to find the points we need to update in contrib

[anuraaga]

PRs for contrib are out

[anuraaga]

Thanks @xrmx I didn't realize test util would be usable without a release - I have sent open-telemetry/opentelemetry-python-contrib#4150 to pass scope explicitly for these failing tests

[anuraaga]

@xrmx I found I had missed a few spots in contrib behind some flaky CI failures and sent open-telemetry/opentelemetry-python-contrib#4165

This time I verified this PR too by temporarily pointing CI at that PR and it was green so should have caught everything this time

https://github.com/open-telemetry/opentelemetry-python/actions/runs/21696227415/job/62566885422?pr=4880