Add PR size guidelines to CONTRIBUTING.md#4888
Open
pmcollins wants to merge 5 commits intoopen-telemetry:mainfrom
Open
Add PR size guidelines to CONTRIBUTING.md#4888pmcollins wants to merge 5 commits intoopen-telemetry:mainfrom
pmcollins wants to merge 5 commits intoopen-telemetry:mainfrom
Conversation
|
Totally agree |
JWinermaSplunk
approved these changes
Jan 29, 2026
JWinermaSplunk
left a comment
There was a problem hiding this comment.
nitpick: I might change If you do this and want the community to understand how your small PR fits into the context of your larger change, to If you want the community to understand how your small PR fits into the context of your larger change, and remove the second incremental from Regardless, strive to provide clear, incremental value to the repository for every incremental change you make, but that is just personal preference. Otherwise, LGTM!
|
PR probably also does not need a CHANGELOG |
emdneto
approved these changes
Jan 29, 2026
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
Member
Author
|
Thanks @emdneto -- I made a few additional tweaks since your suggestion and approval. |
xrmx
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds guidance on keeping pull requests small and focused to improve the review process.
Recommends 500 lines of additions or fewer, which comes from the Collector's CONTRIBUTING.md.
Fixes # (no issue)
Type of change
How Has This Been Tested?
N/A - Documentation-only change. Verified markdown renders correctly.
Does This PR Require a Contrib Repo Change?
Checklist: