TracerProvider(ABC) doc string correction#4894
Open
42Questions wants to merge 2 commits intoopen-telemetry:mainfrom
Open
TracerProvider(ABC) doc string correction#489442Questions wants to merge 2 commits intoopen-telemetry:mainfrom
42Questions wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
emdneto
approved these changes
Feb 3, 2026
Contributor
|
Isn't every instrumentation using |
Author
Yes. I've purposefully done a minimal change, but as mentioned here, a less prescriptive docstring could be warranted:
That said, the current docstring is incorrect: @xrmx Would it make sense to still include a warning about using |
Author
|
@xrmx Can the changelog be skipped for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correction to
class TracerProvider(ABC)docstring, extensively discussed but never implemented open-telemetry/opentelemetry.io#2517 .Correction to
class TracerProvider(ABC).get_meterdocstring as well with the same mistake.