-
Notifications
You must be signed in to change notification settings - Fork 835
fix(otlp-http): reset requests session after fork #4995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dshivashankar1994
wants to merge
4
commits into
open-telemetry:main
Choose a base branch
from
dshivashankar1994:fix_stale_session
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+56
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c2a3133
fix(otlp-http): reset requests session after fork
dshivashankar1994 7ee02b2
Apply suggestions from code review
dshivashankar1994 b53d1fb
Formatting changes per review suggestions
dshivashankar1994 60a57b9
Fix linting errors
dshivashankar1994 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Session() can be customized / modified beyond just the headers.. This sort of breaks people if they are passing in a custom session to the constructor or using the _load_session_from_envvar thing I created.. Both of those features are pretty new and I doubt anyone is really using them yet so not a huge deal..
You could at leastcheck if _load_session_from_envvar returns None or not, and if doesn't use what it returns as the Session..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you suggesting to use the Session returned by
_load_session_from_envvaras is in the forked process ? I believe this is not correct as both parent and forked process will use the same Session, which is what we are trying to avoid here