feat(config): add process resource detector support for declarative config#5001
Open
MikeGoldsmith wants to merge 16 commits intoopen-telemetry:mainfrom
Open
feat(config): add process resource detector support for declarative config#5001MikeGoldsmith wants to merge 16 commits intoopen-telemetry:mainfrom
MikeGoldsmith wants to merge 16 commits intoopen-telemetry:mainfrom
Conversation
Implements create_resource() and create_propagator()/configure_propagator() for the declarative file configuration. Resource creation does not read OTEL_RESOURCE_ATTRIBUTES or run any detectors (matches Java/JS SDK behavior). Propagator configuration always calls set_global_textmap to override Python's default tracecontext+baggage, setting a noop CompositePropagator when no propagator is configured. Assisted-by: Claude Sonnet 4.6
Assisted-by: Claude Sonnet 4.6
- _resource.py: refactor _coerce_attribute_value to dispatch table to avoid too-many-return-statements; fix short variable names k/v -> attr_key/attr_val; fix return type of _sdk_default_attributes to dict[str, str] to satisfy pyright - _propagator.py: rename short variable names e -> exc, p -> propagator - test_resource.py: move imports to top level; split TestCreateResource (25 methods) into three focused classes to satisfy too-many-public-methods - test_propagator.py: add pylint disable for protected-access Assisted-by: Claude Sonnet 4.6
- replace _sdk_default_attributes() with _DEFAULT_RESOURCE from resources module - move _coerce_bool into dispatch tables for both scalar and array bool types, fixing a bug where bool_array with string values like "false" would coerce incorrectly via plain bool() (non-empty string -> True) - add test for bool_array with string values to cover the bug Assisted-by: Claude Sonnet 4.6
… into mike/config-resource-propagator
…erge - collapse _SCALAR_COERCIONS and _ARRAY_COERCIONS into a single _COERCIONS dict using an _array() factory, reducing _coerce_attribute_value to two lines - process attributes_list before attributes so explicit attributes naturally overwrite list entries without needing an explicit guard Assisted-by: Claude Sonnet 4.6
MikeGoldsmith
force-pushed
the
mike/config-resource-detector-process
branch
2 times, most recently
from
a80c64f to
11867ce
Compare
Assisted-by: Claude Sonnet 4.6
Adds _run_detectors() stub and _filter_attributes() to create_resource(), providing the shared scaffolding for detector PRs to build on. Detectors are opt-in: nothing runs unless explicitly listed under detection_development.detectors in the config. The include/exclude attribute filter mirrors other SDK behaviour. Assisted-by: Claude Sonnet 4.6
Merges service.name=unknown_service into base before running detectors, so detectors (e.g. service) can override it. Previously it was added to config_attrs and merged last, which would have silently overridden any detector-provided service.name. Assisted-by: Claude Sonnet 4.6
MikeGoldsmith
force-pushed
the
mike/config-resource-detector-process
branch
from
11867ce to
f2ddbaf
Compare
MikeGoldsmith
added a commit
to MikeGoldsmith/opentelemetry-python
that referenced
this pull request
Mar 20, 2026
Assisted-by: Claude Sonnet 4.6
Assisted-by: Claude Sonnet 4.6
When `resource.detection_development.detectors[].process` is set in the config file, run `ProcessResourceDetector` and merge its output into the resource. Explicit config attributes take priority over detector-provided values. Assisted-by: Claude Sonnet 4.6
Assisted-by: Claude Sonnet 4.6
MikeGoldsmith
force-pushed
the
mike/config-resource-detector-process
branch
from
081e4c1 to
aaf29ef
Compare
…Detector Assisted-by: Claude Sonnet 4.6
1 task
Assisted-by: Claude Sonnet 4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements
processresource detector support increate_resource()for the declarative configuration pipeline, as part of the ongoing work tracked in the following PRs:What's included
detection_development.detectors[].processin the config toProcessResourceDetectorvia_run_detectors()ProcessResourceDetectoronly runs when explicitly listed underdetection_development.detectorsin the configdetection_development.attributesinclude/exclude glob filter (shared infrastructure from feat(config): add resource and propagator creation from declarative config #4979)attributesalways take priority over detector-produced valuesType of change
How Has This Been Tested?
tests/_configuration/test_resource.pydetection_developmentordetectorsis absentDoes This PR Require a Contrib Repo Change?
Checklist:
Assisted-by: Claude Sonnet 4.6