-
Notifications
You must be signed in to change notification settings - Fork 835
feat(config): wire container resource detector via entry point loading #5004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MikeGoldsmith
wants to merge
18
commits into
open-telemetry:main
Choose a base branch
from
MikeGoldsmith:mike/config-resource-detector-container
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+116
−1
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5c26f00
config: add resource and propagator creation from declarative config
MikeGoldsmith 8232012
update changelog with PR number
MikeGoldsmith 8329ae4
fix pylint, pyright and ruff errors in resource/propagator config
MikeGoldsmith 506d816
address review feedback: use _DEFAULT_RESOURCE, fix bool_array coercion
MikeGoldsmith 8232d48
fix linter
MikeGoldsmith 6ed3425
Merge branch 'main' of github.com:open-telemetry/opentelemetry-python…
MikeGoldsmith 99753f9
address review feedback: single coercion table, simplify attributes m…
MikeGoldsmith 8ba91d8
use Callable type annotation on _array helper
MikeGoldsmith 516aecc
Merge remote-tracking branch 'upstream/main' into mike/config-resourc…
MikeGoldsmith 9cfdcce
add detection infrastructure foundations for resource detectors
MikeGoldsmith 103ff08
move service.name default into base resource
MikeGoldsmith 7f51034
remove unused logging import from _propagator.py
MikeGoldsmith e42f1d8
wire container resource detector in declarative config
MikeGoldsmith 327e168
add changelog entry for container resource detector (#5004)
MikeGoldsmith 473a78e
merge upstream/main and fix pylint no-self-use in TestContainerResour…
MikeGoldsmith 22fe70d
add pylint disables for lazy container import in _resource.py
MikeGoldsmith c59bdf1
merge upstream/main
MikeGoldsmith ce15811
load container detector via entry point instead of lazy import
MikeGoldsmith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the env var version uses get_aggregated_resources(). Maybe this should too for consistency -- wdyt?