fix(sdk/trace): cache TracerMetrics on TracerProvider to prevent memory leak#5027
Open
ravitheja4531-cell wants to merge 2 commits intoopen-telemetry:mainfrom
Open
fix(sdk/trace): cache TracerMetrics on TracerProvider to prevent memory leak#5027ravitheja4531-cell wants to merge 2 commits intoopen-telemetry:mainfrom
ravitheja4531-cell wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
xrmx
reviewed
Apr 1, 2026
Contributor
xrmx
left a comment
xrmx
left a comment
There was a problem hiding this comment.
Thanks for the PR. I feel that instead of complicating the tracer we should probably make get_meter cheap instead. Now that the tracer is cached also this should be an issue anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5016
Type of change
How Has This Been Tested?
All 230 existing SDK trace tests pass locally.
Does This PR Require a Contrib Repo Change?
Checklist