Skip to content

Add docker-tests coverage of metrics export#5030

Open
tammy-baylis-swi wants to merge 4 commits intoopen-telemetry:mainfrom
tammy-baylis-swi:add-docker-tests-metrics-export
Open

Add docker-tests coverage of metrics export#5030
tammy-baylis-swi wants to merge 4 commits intoopen-telemetry:mainfrom
tammy-baylis-swi:add-docker-tests-metrics-export

Conversation

@tammy-baylis-swi
Copy link
Copy Markdown
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Apr 1, 2026

Description

Adds docker-tests coverage of metrics export: general test (did not exist), test focused on max_export_batch_size without mocks, for both gRPC and HTTP. Updates the docker-compose for otelcollector version used.

Extending the MetricExporter classes to count batches is hopefully reasonable. Trying to capture otelcollector debug output then parse exact metrics values for "batches forwarded" is too much, imo.

Fixes #5031

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Added more to existing opentelemetry-docker-tests

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review April 1, 2026 23:11
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner April 1, 2026 23:11
@tammy-baylis-swi tammy-baylis-swi requested a review from xrmx April 1, 2026 23:11
@tammy-baylis-swi tammy-baylis-swi moved this to Ready for review in Python PR digest Apr 1, 2026
Copy link
Copy Markdown
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to remove the old mock tests in this PR too? Otherwise a quick followup would be great since it blocks #4976

#4976 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

Add HTTP OTLPMetricExporter docker-test coverage for max_export_batch_size

2 participants