Skip to content

opentelemetry-sdk: fix a bunch of trivial typing issues in metrics#5033

Open
xrmx wants to merge 1 commit intoopen-telemetry:mainfrom
xrmx:fix-metricreader-typing-path
Open

opentelemetry-sdk: fix a bunch of trivial typing issues in metrics#5033
xrmx wants to merge 1 commit intoopen-telemetry:mainfrom
xrmx:fix-metricreader-typing-path

Conversation

@xrmx
Copy link
Copy Markdown
Contributor

@xrmx xrmx commented Apr 2, 2026

Description

This fix the most trivial entries and lists explicitly the files that still have issues in the exclude list so we can at least get a partial type checking.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team as a code owner April 2, 2026 07:16
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 2, 2026
@xrmx xrmx moved this to Easy to review / merge / close in Python PR digest Apr 2, 2026
@xrmx xrmx moved this from Easy to review / merge / close to Approved PRs in Python PR digest Apr 2, 2026
Copy link
Copy Markdown
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Approved PRs

Development

Successfully merging this pull request may close these issues.

4 participants