fix: ensure major ruby updates need approval#1910
Merged
arielvalentin merged 1 commit intoopen-telemetry:mainfrom Jan 5, 2026
Merged
fix: ensure major ruby updates need approval#1910arielvalentin merged 1 commit intoopen-telemetry:mainfrom
arielvalentin merged 1 commit intoopen-telemetry:mainfrom
Conversation
thompson-tomo
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
This was referenced Jan 5, 2026
arielvalentin
approved these changes
Jan 5, 2026
Contributor
arielvalentin
left a comment
arielvalentin
left a comment
There was a problem hiding this comment.
🤞🏼 Hopefully this does the trick.
Is there no way to test these configurations on a branch?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #1900
The linked pr didn't achieve its objective of requiring approval of major ruby updates based on the pr's that have been raised, it looks to be due to the approval requirement not removing the schedule, hence have split major non ruby packages into their own rule.
This will have blocked #1905 #1906 #1908 and #1909 from being raised and instead have required approval first.