feat: Add release tag into source code url of gem metadata#1984
Merged
arielvalentin merged 5 commits intoopen-telemetry:mainfrom Apr 11, 2026
Merged
feat: Add release tag into source code url of gem metadata#1984arielvalentin merged 5 commits intoopen-telemetry:mainfrom
arielvalentin merged 5 commits intoopen-telemetry:mainfrom
Conversation
thompson-tomo
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
github-actions
Bot
assigned
indrekj,
jj22ee,
MikeGoldsmith,
muripic,
NathanielRN,
robbkidd,
robertlaurin and
scbjans
thompson-tomo
changed the title
thompson-tomo
changed the title
Contributor
|
Would using tags instead of SHA be a better user experience? |
Contributor
Author
|
Both achieve the same result and experience, tags are nicer for users using github but we would need to extend the CI to be adding tags and using them. The nice thing about commits is that they are always available to both ci/users and can not be tampered with. |
thompson-tomo
force-pushed
the
feat/#1961_AddCommitId
branch
from
45fe33e to
b9cca80
Compare
github-actions
Bot
added
instrumentation-active_storage
instrumentation-active_support
instrumentation-anthropic
instrumentation-aws_sdk
instrumentation-aws_lambda
instrumentation-base
instrumentation-bunny
instrumentation-concurrent_ruby
instrumentation-dalli
instrumentation-delayed_job
instrumentation-ethon
instrumentation-excon
instrumentation-factory_bot
instrumentation-faraday
instrumentation-grape
instrumentation-graphql
instrumentation-grpc
instrumentation-gruf
instrumentation-http_client
instrumentation-httpx
instrumentation-koala
instrumentation-lmdb
instrumentation-logger
instrumentation-mongo
labels
Contributor
Author
|
@robbkidd / @dazuma / @arielvalentin i have switched to using the tag rather than commit. Please take a look. |
arielvalentin
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1961
This tweaks the gemspec files so that the source code url now contains the release tag. By including this tag, we can as part of deprecation work remove the source files while having atleast the latest published version of gem pointing to the code used and a readme containing the deprecation
Note the only other change was to update
resources/aws/opentelemetry-resource-detector-aws.gemspecso that it was the same metadata as the other gems.