OTLP Examples fixed to be consistent#1752
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1752 +/- ##
=======================================
+ Coverage 71.0% 71.6% +0.5%
=======================================
Files 135 136 +1
Lines 20751 20845 +94
=======================================
+ Hits 14746 14931 +185
+ Misses 6005 5914 -91 ☔ View full report in Codecov by Sentry. |
#1706 might have broken the endpoint. |
The metrics endpoint should work as after #1706 we won't change anything from user input in builders. For logs, we need to manually append the |
Its still not working. :( Could you take a look ? "Error: Other("[Other(reqwest::Error { kind: Status(400), url: Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("localhost")), port: Some(4318), path: "/v1/logs", query: None, fragment: None } })]")" |
lalitb
left a comment
There was a problem hiding this comment.
LGTM. Assuming the issue of OTLP HTTP Log Exporter would be handled separately.
Yeah taking a look now |
Bad Request, Could also be related to PR for sending Resource separately, and then combining before export. Let me check too :( |
|
Alright I think there are some issues with OTLP http/json exporter. After set the http binary protocol everything works fine |
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
Fix the example to use same Resource for all signals.
The http one is now matching the grpc one, though I plan to send a follow up later to maintain single example with feature flag to control transport, as opposed to copying a lot.
Also, the http one is not working for logs, metrics. (this was same before this PR also, so not a blocker for this PR.)