HDF5: Close operations also upon failure#1866
Open
franzpoeschel wants to merge 2 commits intoopenPMD:devfrom
Open
HDF5: Close operations also upon failure#1866franzpoeschel wants to merge 2 commits intoopenPMD:devfrom
franzpoeschel wants to merge 2 commits intoopenPMD:devfrom
Conversation
retrigger ci
franzpoeschel
force-pushed
the
hdf5-fix-nonexistent-attribute-read
branch
from
08a93f1 to
dfb7d8c
Compare
Apply the defer pattern (introduced in readAttribute fix) to ensure HDF5 resources are properly closed when exceptions occur in writeAttribute, readDataset, listPaths, listDatasets, listAttributes, and deleteAttribute. The defer pattern uses auxiliary::defer to register cleanup callbacks that run automatically when the function exits, ensuring resources are released even when errors occur mid-function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically our entire HDF5 implementation is a resource leak in the error case. This PR uses RAII to implement a deferred cleanup operation (similar to how Go handles resource freeing)
TODO: