Skip to content

user, password and url for dc adapter#3135

Open
LKuemmel wants to merge 1 commit intoopenWB:masterfrom
LKuemmel:dc_adapter
Open

user, password and url for dc adapter#3135
LKuemmel wants to merge 1 commit intoopenWB:masterfrom
LKuemmel:dc_adapter

Conversation

@LKuemmel
Copy link
Contributor

@LKuemmel LKuemmel requested a review from benderl February 10, 2026 14:02
@LKuemmel LKuemmel added this to the 2.2.0 - Step 1 milestone Feb 10, 2026
@seaspotter
Copy link
Contributor

#3118 Entweder hier oder dort muss dann der Datastore um eins hochgezählt werden, je nachdem was zuerst gemergt wird.

Comment on lines +2710 to +2716
if config["configuration"].get("user") is None:
config["configuration"]["user"] = None
if config["configuration"].get("password") is None:
config["configuration"]["password"] = None
if config["configuration"].get("ip_address") is not None:
ip_address = config["configuration"].pop("ip_address")
config["configuration"]["url"] = f'http://{ip_address}/connect.php'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vor dem Upgrade sind die Bedingungen immer erfüllt.

Suggested change
if config["configuration"].get("user") is None:
config["configuration"]["user"] = None
if config["configuration"].get("password") is None:
config["configuration"]["password"] = None
if config["configuration"].get("ip_address") is not None:
ip_address = config["configuration"].pop("ip_address")
config["configuration"]["url"] = f'http://{ip_address}/connect.php'
config["configuration"]["user"] = None
config["configuration"]["password"] = None
ip_address = config["configuration"].pop("ip_address")
config["configuration"]["url"] = f'http://{ip_address}/connect.php'

@benderl benderl added the ui depends on changes in ui repository label Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui depends on changes in ui repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants