Attach guardian rollouts to feedback uploads#15082
Open
charley-oai wants to merge 4 commits intomainfrom
Open
Conversation
Add guardian review_thread_id plumbing so feedback can resolve the hidden guardian session rollout and attach it alongside the parent rollout in both app-server and local /feedback flows. Co-authored-by: Codex <noreply@openai.com>
Collaborator
Author
|
@codex review |
Keep the guardian rollout attachment plumbing for /feedback uploads, but remove the unnecessary app-server notification/schema field so the PR stays narrowly scoped. Co-authored-by: Codex <noreply@openai.com>
Use guardian-specific naming in guardian assessment events and keep backward compatibility for older rollout JSON via a deserialization alias. Co-authored-by: Codex <noreply@openai.com>
Use the rollout attachment helper directly and rely on its empty result for feedback uploads without logs. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
review_thread_idto guardian assessment events and surface it through guardian approval review notifications/feedbackuploads/feedbackflows intuiandtui_app_serverto attach and display guardian rollout attachments tooNotes
cargo test -p codex-corestill hits the existing unrelatedtools::js_repl::tests::js_repl_imported_local_files_can_access_repl_globalsfailure (mktemp ... Operation not permitted).cargo test -p codex-app-serverstill hits existing unrelated integrationdeadline has elapsedfailures; the guardian-specific unit coverage for this change passed.