fix: treat empty OPENAI_BASE_URL same as None for default fallback

[vivekvar-dl]

Fix: Empty OPENAI_BASE_URL prevents fallback to default endpoint

Fixes #2927

Problem

When OPENAI_BASE_URL is set but empty, client initialization fails with APIConnectionError:

export OPENAI_BASE_URL=""
python -c "from openai import OpenAI; OpenAI().models.list()"
# ❌ openai.APIConnectionError: Connection error

Root cause: os.environ.get("OPENAI_BASE_URL") returns "" (empty string), not None. The current logic only checks if base_url is None, so the empty string bypasses the fallback:

if base_url is None:
    base_url = os.environ.get("OPENAI_BASE_URL")  # Returns ""
if base_url is None:  # ❌ False! "" is not None
    base_url = "https://api.openai.com/v1"  # Never reached

---

Solution

Change second condition from if base_url is None to if not base_url:

if base_url is None:
    base_url = os.environ.get("OPENAI_BASE_URL")
# NEW: Treat empty string same as None
if not base_url:  # ✅ Catches both None and ""
    base_url = "https://api.openai.com/v1"

---

Changes

File: src/openai/_client.py

• Line 167 (OpenAI sync client)
• Line 544 (AsyncOpenAI async client)

Both instances updated identically.

---

Safety

✅ Pythonic: not base_url is idiomatic for "None or empty"
✅ Backward compatible:

• base_url=None → still falls through ✅
• OPENAI_BASE_URL not set → still falls through ✅
• OPENAI_BASE_URL="https://custom" → still used ✅
• base_url="https://custom" (explicit) → still used ✅

✅ Better UX: Empty string would cause connection error anyway; falling back to default is more helpful

---

Testing

Before:

export OPENAI_BASE_URL=""
python3 -c "from openai import OpenAI; print(OpenAI()._client.base_url)"
# Output: (empty, causes connection error)

After:

export OPENAI_BASE_URL=""
python3 -c "from openai import OpenAI; print(OpenAI()._client.base_url)"
# Output: https://api.openai.com/v1

---

Edge Cases Handled

Scenario	Before	After
OPENAI_BASE_URL unset	Default URL ✅	Default URL ✅
OPENAI_BASE_URL=""	Empty (breaks) ❌	Default URL ✅
OPENAI_BASE_URL="https://custom"	Custom URL ✅	Custom URL ✅
base_url="https://custom" (param)	Custom URL ✅	Custom URL ✅

---

Why This Matters

• Common mistake: Users unset env vars with export VAR="" instead of unset VAR
• Confusing error: Connection error doesn't mention the empty env var
• Simple fix: One condition change, huge UX improvement

---

Related

• Issue: Empty OPENAI_BASE_URL prevents fallback to default API endpoint #2927
• Reported by: Multiple users with empty env vars
• Pattern used in: Many Python libraries (requests, httpx, etc.)

---

Checklist:

• Fixes root cause (empty string not treated as None)
• Both sync and async clients updated
• Backward compatible
• Pythonic solution
• Clear commit message

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17b4fdb3b7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Don't override an explicitly empty base_url

if not base_url broadens this fix from the empty OPENAI_BASE_URL env var to the explicit base_url argument as well. That changes constructor behavior for callers that intentionally pass base_url="" with a custom http_client/transport to keep requests relative: _prepare_url() in _base_client.py concatenates relative request paths with self.base_url, so this used to stay on the caller's transport, but after this change it silently falls back to https://api.openai.com/v1. Limiting the fallback to env-derived values would preserve that existing override semantics.

Useful? React with 👍 / 👎.