fixed how array fields are sent in multipart form POSTs#249
Open
ben5516 wants to merge 4 commits intoopenai:mainfrom
Open
fixed how array fields are sent in multipart form POSTs#249ben5516 wants to merge 4 commits intoopenai:mainfrom
ben5516 wants to merge 4 commits intoopenai:mainfrom
Conversation
It’s not necessary to url_encode the field keys, and that breaks timestamp_granularities[], among other things
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d94e79a2b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a naive approach to properly supporting array fields in multipart encoded POST requests.
The issue I was having was that this code was not correctly sending
timestamp_granularitiesto the server (see example):The server is expecting an array field, where the key is
timestamp_granularities[]. However, theurl_encodesanitization pass encodes the square brackets and the server doesn't decode it. Sanitization should be less aggressive, and only escapeLF,CR,", and\I believe.