fix: reject conflicting auth sources instead of silently preferring ?token=#36
Open
xyaz1313 wants to merge 1 commit intoopenapi:mainfrom
Open
fix: reject conflicting auth sources instead of silently preferring ?token=#36xyaz1313 wants to merge 1 commit intoopenapi:mainfrom
xyaz1313 wants to merge 1 commit intoopenapi:mainfrom
Conversation
…token= When both Authorization header and ?token= query parameter are provided, the middleware previously stripped the header and used the query token without any warning. This could hide client misconfiguration. Now returns 400 with a clear error message when both are present. Fixes openapi#27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27
Problem
When both header and query parameter are provided, silently replaces the header with the query token. This hides client misconfiguration and makes debugging auth problems harder.
Fix
Reject the request with when both auth sources are present, returning a clear error message. This makes the conflict visible immediately rather than silently choosing one.
Behavior: