fixup scripts; add Makefile for buttons (not a.out)#19
Open
thecubic wants to merge 3 commits intoopenaps:masterfrom
Open
fixup scripts; add Makefile for buttons (not a.out)#19thecubic wants to merge 3 commits intoopenaps:masterfrom
thecubic wants to merge 3 commits intoopenaps:masterfrom
Conversation
Contributor
|
Thanks for the cleanup :) the original button code was a quick-and-dirty hack to make the buttons usable while Bryan was working on these (which we should be moving to when I have a chance to write the installer): https://github.com/bnielsen1965/node-pi-buttons https://github.com/bnielsen1965/pi-buttons |
Collaborator
|
@cluckj I have a setup script for pi-buttons service that I am using in another project, it might work for your needs or provide a starting point... |
Contributor
|
@cluckj want to review this and merge when ready, or LMK if you need perms? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is really just generalized scripts cleanup; it moves
a.outbuttons to just abuttonsexecutable with a Makefile (and removes it from revision control - it's going to be executed as root).setup.sh will now do the build if the helper binary is not present, and also it will not change already correctly-configured GPIO settings (re-exporting is an error), and does an access check with guidance when not permitted (the caller only needs to be in the gpio group)
Testing: I am looping with this and it works