This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Orchestrator analysis-locked-hypothesis test is unstable#1465
Open
kamil-holubicki wants to merge 1 commit intoopenark:masterfrom
Open
Orchestrator analysis-locked-hypothesis test is unstable#1465kamil-holubicki wants to merge 1 commit intoopenark:masterfrom
kamil-holubicki wants to merge 1 commit intoopenark:masterfrom
Conversation
openark#1464 Problem: analysis-locked-hypothesis test is unstable Cause: By default instance is polled every 5 seconds, but we wait only for 2 seconds, so it may happen that instance is not polled before we get the analysis result. Solution: Wait for 7 seconds after disabling instance. It is 7 because it has to be > 5 but LockedSemiSyncMasterHypothesis is reported only within 6 secs window (InstancePollSeconds + ReasonableInstanceCheckSeconds), then it switches to LockedSemiSyncMaster status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1464
Problem:
analysis-locked-hypothesis test is unstable
Cause:
By default instance is polled every 5 seconds, but we wait only for 2 seconds, so it may happen that instance is not polled before we get the analysis result.
Solution:
Wait for 7 seconds after disabling instance. It is 7 because it has to be > 5 but LockedSemiSyncMasterHypothesis is reported only within 6 secs window (InstancePollSeconds + ReasonableInstanceCheckSeconds), then it switches to LockedSemiSyncMaster status.
Related issue: https://github.com/openark/orchestrator/issues/0123456789
Description
This PR [briefly explain what is does]