Skip to content

fix(build): Make Makefile work without GOBIN in PATH or uvx installed #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix(build): Make Makefile work without GOBIN in PATH or uvx installed #124

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e93f446
Initial plan
Copilot Feb 10, 2026
43b6d44
fix(build): allow Makefile to work without GOBIN in PATH
Copilot Feb 10, 2026
87d1bc6
fix(build): make uvx optional for lint and provide better error messages
Copilot Feb 10, 2026
4b3ab3e
fix(build): redirect uvx warning to stderr in lint target
Copilot Feb 10, 2026
dc91e5b
fix(build): make PATH suggestion consistent with actual usage
Copilot Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,14 @@ lint:
--show-stats=false --fix
@gofmt -l . # Lists files that are likely to be changed by the next command
@go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.4.0 fmt
@uvx -q sqlfluff fix -q \
--disable-progress-bar \
--config=internal/server/postgres/sql/.sqlfluff.toml \
internal/server/postgres/sql/queries
@if command -v uvx > /dev/null 2>&1; then \
uvx -q sqlfluff fix -q \
--disable-progress-bar \
--config=internal/server/postgres/sql/.sqlfluff.toml \
internal/server/postgres/sql/queries; \
else \
echo "Warning: uvx not found, skipping SQL linting" >&2; \
fi

.PHONY: bench
bench: gen
Expand Down Expand Up @@ -101,7 +105,7 @@ ${SQLC_STAMP_FILE}: ${SQLC} ${SQLC_SOURCES} ${SQLC_SOURCE_CONFIG}
${PROTO_GO_STAMP_FILE}: ${PROTOC} ${PROTOC_GEN_GO} ${PROTOC_GEN_GRPC} ${PROTO_SOURCES}
@echo "Generating internal protobuf code..."
@rm -rf internal/gen && mkdir -p internal/gen
@${PROTOC} \
@PATH="$(GOBIN):$$PATH" ${PROTOC} \
${PROTO_SOURCES} \
-I=proto \
--go_out=internal/gen \
Expand All @@ -116,8 +120,7 @@ ${PROTO_GO_STAMP_FILE}: ${PROTOC} ${PROTOC_GEN_GO} ${PROTOC_GEN_GRPC} ${PROTO_SO
.PHONY: path
path:
@if ! echo "$$PATH" | tr ':' '\n' | grep -qx "$(GOBIN)"; then \
echo "Add 'export PATH=$$PATH:$(GOBIN)' to your shell profile to use installed tools."; \
exit 1; \
echo "Warning: $(GOBIN) is not in PATH. Add 'export PATH=$(GOBIN):$$PATH' to your shell profile to use installed tools."; \
fi

.PHONY: tools
Expand Down Expand Up @@ -179,6 +182,11 @@ endef
export GEN_PYPROJ
.PHONY: gen.proto.python
gen.proto.python: ${PROTOC}
@if ! command -v uvx > /dev/null 2>&1; then \
echo "Error: uvx is required for Python bindings generation but not found."; \
echo "Please install uv: https://docs.astral.sh/uv/getting-started/installation/"; \
exit 1; \
fi
@echo "Generating Python client bindings..."
@rm -rf gen/python && mkdir -p gen/python/src/dp_sdk
@uvx --from 'betterproto[compiler]==2.0.0b7' ${PROTOC} \
Expand Down