forecast/all get timeseries if gsp_ids are set#196
Merged
peterdudfield merged 3 commits intomainfrom Mar 4, 2026
Merged
Conversation
peterdudfield
changed the title
devsjc
reviewed
Mar 4, 2026
| ) | ||
| # if gsp ids are not set, then we use snapshot method, which gets all gsps for one timestamp | ||
| # if gsp_ids is set, then we loop over all gsp ids to get forecasts. The UI current needs this. | ||
| if gsp_ids is None: |
Contributor
There was a problem hiding this comment.
Wasn't there an intention to make it so fewer than 10 could have simultaneous timeseries collection or something?
Contributor
Author
There was a problem hiding this comment.
This changed, as we realised that DNOs have a lot more than 10 gsps in them, and we need it to work for that
Contributor
Author
There was a problem hiding this comment.
The idea would be to move the UI over to use gsp/{gps_id}/forecast when possible. But atleast this should work
Contributor
There was a problem hiding this comment.
Oh do we get timeseries forecasts for whole DNOs at a time?
Contributor
Author
There was a problem hiding this comment.
yea DNO is done by gsp/forecast/all/?gsp_ids=[x_1,x2, ...x_20,....]
and we can select mutlie DNOs too
devsjc
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
For the forecast/all route, if gsp_ids is not None, then we get full predictions.
If gsp_ids is None, then we just get one timestamp
We decided not to limit to gsp ids of 10, as the DNO view on the UI loads more than 10 gsp ids
#195
How Has This Been Tested?
Checklist: