Open
Conversation
Contributor
Author
Member
@ScharfViktor offered to try this out. |
Checklist
|
Contributor
Author
|
@ScharfViktor thank you for testing. |
|
after 12 hours I open opencloud app on my android again. what I see:
Result: note: yesterday I deleted all |
Contributor
Author
|
@ScharfViktor Do you have the client log file for this one?
CC @Svanvith in case you changed something or know something |
Contributor
Author
|
Interestingly it works for me, I get a new token today. It doesn't ask me to re-login. I will delete account and check. |
Contributor
Author
Wait a sec, on that server I didn't use the alan account but another one. So maybe that's why I did not see same behaviour as you. I'll add new account alan. EDIT: I can login with account alan no problem. Will try timeouting it. @ScharfViktor How do you recover from this error in the web view? |
|
hmm, I still can't log in. I'm trying to get log. send you here later screen-20260305-095526.mp4
I can delete your session and you will try to login again. let's try? |
|
log: |
I asked, nothing was changed |
Contributor
Author
|
@ScharfViktor I think I need to reproduce it myself. Or you give me the fuller log, because my log has things like this which your "grep opencloud" filters out |
|
Bug description:
Here is bug - wrong
no successful login -> redirect to app with setting server address |
guruz
force-pushed
the
webfinger_client_id
branch
from
5b65332 to
168ffb7
Compare
To solve many of the issues our users have with getting OpenCloud to work with different IDPs we came up with a more generic way for how clients should discover their OIDC setttings (issuer, client_id and scopes). This is described here: https://github.com/opencloud-eu/opencloud/blob/main/docs/adr/0003-oidc-client-config-discovery.md This is for #96
When Android kills the app process while the user is in the browser for OAuth login, the OAuth redirect creates a fresh LoginActivity with no ViewModel state. This caused a MalformedURLException because the token endpoint URL was built from an empty serverBaseUrl. Unlike activity death (where onSaveInstanceState Bundle survives), process death requires SharedPreferences to persist state across the browser redirect. The existing commit feba750 saved PKCE state to SharedPreferences but missed serverBaseUrl. Fix by: - Saving serverBaseUrl and oidcSupported to SharedPreferences alongside the existing PKCE state - On OAuth redirect after process death, re-running OIDC discovery (getServerInfo) to repopulate the ViewModel before processing the authorization code - Always launching FileDisplayActivity after successful account discovery, so the user lands in the app instead of Chrome coming back to foreground (cherry picked from commit a7b0863)
This is to show a nice username "username" instead of "long-uuid@server" in the web form.
guruz
force-pushed
the
webfinger_client_id
branch
from
532d763 to
8a0d4b1
Compare
Tested. works fine. I can re-login. Thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To solve many of the issues our users have with getting OpenCloud to work with different IDPs we came up with a more generic way for how clients should discover their OIDC setttings (issuer, client_id and scopes).
This is described here:
https://github.com/opencloud-eu/opencloud/blob/main/docs/adr/0003-oidc-client-config-discovery.md
This is for #96
I will create a test build and link it here in the comments...
Thank you @Svanvith for test server