feat(graph/education): Add support of 'eq' filters on users#2421
Open
rhafer wants to merge 5 commits intoopencloud-eu:mainfrom
Open
feat(graph/education): Add support of 'eq' filters on users#2421rhafer wants to merge 5 commits intoopencloud-eu:mainfrom
rhafer wants to merge 5 commits intoopencloud-eu:mainfrom
Conversation
This adds support of simple OData filters on the 'education/users' endpoint. Filters of the type '$filter=<attr> eq <value>' are supported now for the following educationUser properties: "displayname", "mail", "userType", "primaryRole" and "externalId" Closes: opencloud-eu#1599
Remove the ability to look up schools by externalId directly (from LDAP filters, duplicate checks, and the EducationBackend interface). This approach was somewhat unclean, we shouldn't add more an more attributes as keys for direct lookup. Instead, expose externalId filtering via the OData $filter query parameter on GET /education/schools, following the same pattern as for education users. Related: opencloud-eu#1598
rhafer
force-pushed
the
issue/1599
branch
2 times, most recently
from
0e23d24 to
c7f463e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support of simple OData filters on the 'education/users' endpoint. Filters of the type '$filter= eq ' are supported now for the following educationUser properties: "displayname", "mail", "userType", "primaryRole" and "externalId"
To keep the endpoints for users and schools somewhat consistent I also added $filter support to the educations/schools endpoint and removed the code that does allow referencing schools directly via
externalId.Closes: #1599