Skip to content

feat: use proper size-5 class for medium sized icons #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kulmann merged 2 commits into from
Mar 6, 2026
Merged

feat: use proper size-5 class for medium sized icons #2066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1ab3f5
feat: use proper size-5 class for medium sized icons
JammingBen Mar 3, 2026
5a71cff
feat: use line icons for share role icons
JammingBen Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/design-system/src/components/OcIcon/OcIcon.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const nameWithFillType = computed(() => {
const tailwindSize = computed(() => ({
'size-3': size === 'xsmall',
'size-4': size === 'small',
'size-5.5': size === 'medium',
'size-5': size === 'medium',
'size-8': size === 'large',
'size-12': size === 'xlarge',
'size-22': size === 'xxlarge',
Expand Down
24 changes: 12 additions & 12 deletions ...web-app-admin-settings/tests/unit/components/Spaces/__snapshots__/SpacesList.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,15 +122,15 @@ exports[`SpacesList > should render all spaces in a table 1`] = `
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle w-px oc-td oc-table-data-cell oc-table-data-cell-select pl-4">
<oc-checkbox-stub option="undefined" label="Select 1 Some space" disabled="false" id="oc-checkbox-2" labelhidden="true" size="large" modelvalue="false"></oc-checkbox-stub>
</td>
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle w-px oc-td oc-table-data-cell oc-table-data-cell-icon"><span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5.5"><svg data-testid="inline-svg-stub" src="icons/layout-grid-fill.svg" transform-source="(svg) => {
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle w-px oc-td oc-table-data-cell oc-table-data-cell-icon"><span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5"><svg data-testid="inline-svg-stub" src="icons/layout-grid-fill.svg" transform-source="(svg) => {
if (__props.accessibleLabel !== &quot;&quot;) {
const title = document.createElement(&quot;title&quot;);
title.setAttribute(&quot;id&quot;, svgTitleId.value);
title.appendChild(document.createTextNode(__props.accessibleLabel));
svg.insertBefore(title, svg.firstChild);
};
return svg;
}" aria-hidden="true" focusable="false" class="size-5.5"></svg></span></td>
}" aria-hidden="true" focusable="false" class="size-5"></svg></span></td>
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle min-w-38 oc-td oc-table-data-cell oc-table-data-cell-name mark-element"><span data-test-space-name="1 Some space">1 Some space</span></td>
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle oc-td oc-table-data-cell oc-table-data-cell-status"><span class="flex items-center"><span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-4"><svg data-testid="inline-svg-stub" src="icons/play-circle-line.svg" transform-source="(svg) => {
if (__props.accessibleLabel !== &quot;&quot;) {
Expand All @@ -150,26 +150,26 @@ exports[`SpacesList > should render all spaces in a table 1`] = `
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-right align-middle oc-td oc-table-data-cell oc-table-data-cell-actions pr-4">
<div class="spaces-list-actions"><button type="button" aria-label="Show details" class="oc-button-secondary oc-button-raw oc-button-secondary-raw gap-2 justify-center text-base min-h-4 oc-button cursor-pointer disabled:opacity-60 disabled:cursor-default ml-1 quick-action-button p-1 spaces-table-btn-details">
<!--v-if-->
<!-- @slot Content of the button --> <span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5.5"><svg data-testid="inline-svg-stub" src="icons/information-line.svg" transform-source="(svg) => {
<!-- @slot Content of the button --> <span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5"><svg data-testid="inline-svg-stub" src="icons/information-line.svg" transform-source="(svg) => {
if (__props.accessibleLabel !== &quot;&quot;) {
const title = document.createElement(&quot;title&quot;);
title.setAttribute(&quot;id&quot;, svgTitleId.value);
title.appendChild(document.createTextNode(__props.accessibleLabel));
svg.insertBefore(title, svg.firstChild);
};
return svg;
}" aria-hidden="true" focusable="false" class="size-5.5"></svg></span>
}" aria-hidden="true" focusable="false" class="size-5"></svg></span>
</button> <button type="button" aria-label="Show context menu" class="oc-button-secondary oc-button-raw oc-button-secondary-raw gap-2 justify-center text-base min-h-4 oc-button cursor-pointer disabled:opacity-60 disabled:cursor-default quick-action-button ml-1 p-1 spaces-table-btn-action-dropdown" id="context-menu-trigger-1" data-test-context-menu-resource-name="1 Some space">
<!--v-if-->
<!-- @slot Content of the button --> <span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5.5"><svg data-testid="inline-svg-stub" src="icons/more-2-fill.svg" transform-source="(svg) => {
<!-- @slot Content of the button --> <span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5"><svg data-testid="inline-svg-stub" src="icons/more-2-fill.svg" transform-source="(svg) => {
if (__props.accessibleLabel !== &quot;&quot;) {
const title = document.createElement(&quot;title&quot;);
title.setAttribute(&quot;id&quot;, svgTitleId.value);
title.appendChild(document.createTextNode(__props.accessibleLabel));
svg.insertBefore(title, svg.firstChild);
};
return svg;
}" aria-hidden="true" focusable="false" class="size-5.5"></svg></span>
}" aria-hidden="true" focusable="false" class="size-5"></svg></span>
</button>
<transition-stub name="oc-drop" appear="false" persisted="false" css="true">
<!--v-if-->
Expand All @@ -181,15 +181,15 @@ exports[`SpacesList > should render all spaces in a table 1`] = `
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle w-px oc-td oc-table-data-cell oc-table-data-cell-select pl-4">
<oc-checkbox-stub option="undefined" label="Select 2 Another space" disabled="false" id="oc-checkbox-3" labelhidden="true" size="large" modelvalue="false"></oc-checkbox-stub>
</td>
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle w-px oc-td oc-table-data-cell oc-table-data-cell-icon"><span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5.5"><svg data-testid="inline-svg-stub" src="icons/layout-grid-fill.svg" transform-source="(svg) => {
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle w-px oc-td oc-table-data-cell oc-table-data-cell-icon"><span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5"><svg data-testid="inline-svg-stub" src="icons/layout-grid-fill.svg" transform-source="(svg) => {
if (__props.accessibleLabel !== &quot;&quot;) {
const title = document.createElement(&quot;title&quot;);
title.setAttribute(&quot;id&quot;, svgTitleId.value);
title.appendChild(document.createTextNode(__props.accessibleLabel));
svg.insertBefore(title, svg.firstChild);
};
return svg;
}" aria-hidden="true" focusable="false" class="size-5.5"></svg></span></td>
}" aria-hidden="true" focusable="false" class="size-5"></svg></span></td>
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle min-w-38 oc-td oc-table-data-cell oc-table-data-cell-name mark-element"><span data-test-space-name="2 Another space">2 Another space</span></td>
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle oc-td oc-table-data-cell oc-table-data-cell-status"><span class="flex items-center"><span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-4"><svg data-testid="inline-svg-stub" src="icons/stop-circle-line.svg" transform-source="(svg) => {
if (__props.accessibleLabel !== &quot;&quot;) {
Expand All @@ -209,26 +209,26 @@ exports[`SpacesList > should render all spaces in a table 1`] = `
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-right align-middle oc-td oc-table-data-cell oc-table-data-cell-actions pr-4">
<div class="spaces-list-actions"><button type="button" aria-label="Show details" class="oc-button-secondary oc-button-raw oc-button-secondary-raw gap-2 justify-center text-base min-h-4 oc-button cursor-pointer disabled:opacity-60 disabled:cursor-default ml-1 quick-action-button p-1 spaces-table-btn-details">
<!--v-if-->
<!-- @slot Content of the button --> <span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5.5"><svg data-testid="inline-svg-stub" src="icons/information-line.svg" transform-source="(svg) => {
<!-- @slot Content of the button --> <span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5"><svg data-testid="inline-svg-stub" src="icons/information-line.svg" transform-source="(svg) => {
if (__props.accessibleLabel !== &quot;&quot;) {
const title = document.createElement(&quot;title&quot;);
title.setAttribute(&quot;id&quot;, svgTitleId.value);
title.appendChild(document.createTextNode(__props.accessibleLabel));
svg.insertBefore(title, svg.firstChild);
};
return svg;
}" aria-hidden="true" focusable="false" class="size-5.5"></svg></span>
}" aria-hidden="true" focusable="false" class="size-5"></svg></span>
</button> <button type="button" aria-label="Show context menu" class="oc-button-secondary oc-button-raw oc-button-secondary-raw gap-2 justify-center text-base min-h-4 oc-button cursor-pointer disabled:opacity-60 disabled:cursor-default quick-action-button ml-1 p-1 spaces-table-btn-action-dropdown" id="context-menu-trigger-2" data-test-context-menu-resource-name="2 Another space">
<!--v-if-->
<!-- @slot Content of the button --> <span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5.5"><svg data-testid="inline-svg-stub" src="icons/more-2-fill.svg" transform-source="(svg) => {
<!-- @slot Content of the button --> <span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5"><svg data-testid="inline-svg-stub" src="icons/more-2-fill.svg" transform-source="(svg) => {
if (__props.accessibleLabel !== &quot;&quot;) {
const title = document.createElement(&quot;title&quot;);
title.setAttribute(&quot;id&quot;, svgTitleId.value);
title.appendChild(document.createTextNode(__props.accessibleLabel));
svg.insertBefore(title, svg.firstChild);
};
return svg;
}" aria-hidden="true" focusable="false" class="size-5.5"></svg></span>
}" aria-hidden="true" focusable="false" class="size-5"></svg></span>
</button>
<transition-stub name="oc-drop" appear="false" persisted="false" css="true">
<!--v-if-->
Expand Down
12 changes: 6 additions & 6 deletions packages/web-app-admin-settings/tests/unit/views/__snapshots__/Users.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ exports[`Users view > list view > renders initially warning if filters are manda
</div>
<div class="user-filters flex justify-between flex-wrap items-end mx-4 mb-4">
<div class="flex items-center">
<div class="mr-4 flex items-center"><span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5.5 mr-1"><svg data-testid="inline-svg-stub" src="icons/filter-2-fill.svg" transform-source="(svg) => {
<div class="mr-4 flex items-center"><span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5 mr-1"><svg data-testid="inline-svg-stub" src="icons/filter-2-fill.svg" transform-source="(svg) => {
if (__props.accessibleLabel !== &quot;&quot;) {
const title = document.createElement(&quot;title&quot;);
title.setAttribute(&quot;id&quot;, svgTitleId.value);
title.appendChild(document.createTextNode(__props.accessibleLabel));
svg.insertBefore(title, svg.firstChild);
};
return svg;
}" aria-hidden="true" focusable="false" class="size-5.5"></svg></span> <span>Filter:</span></div>
}" aria-hidden="true" focusable="false" class="size-5"></svg></span> <span>Filter:</span></div>
<item-filter-stub filterlabel="Groups" items="undefined" filtername="groups" optionfilterlabel="Filter groups" showoptionfilter="true" allowmultiple="true" idattribute="id" displaynameattribute="displayName" filterableattributes="displayName" closeonclick="false" class="mr-2"></item-filter-stub>
<item-filter-stub filterlabel="Roles" items="[object Object],[object Object],[object Object],[object Object]" filtername="roles" optionfilterlabel="Filter roles" showoptionfilter="true" allowmultiple="true" idattribute="id" displaynameattribute="displayName" filterableattributes="displayName" closeonclick="false"></item-filter-stub>
</div>
Expand Down Expand Up @@ -72,15 +72,15 @@ exports[`Users view > list view > renders list initially 1`] = `
</div>
<div class="user-filters flex justify-between flex-wrap items-end mx-4 mb-4">
<div class="flex items-center">
<div class="mr-4 flex items-center"><span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5.5 mr-1"><svg data-testid="inline-svg-stub" src="icons/filter-2-fill.svg" transform-source="(svg) => {
<div class="mr-4 flex items-center"><span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5 mr-1"><svg data-testid="inline-svg-stub" src="icons/filter-2-fill.svg" transform-source="(svg) => {
if (__props.accessibleLabel !== &quot;&quot;) {
const title = document.createElement(&quot;title&quot;);
title.setAttribute(&quot;id&quot;, svgTitleId.value);
title.appendChild(document.createTextNode(__props.accessibleLabel));
svg.insertBefore(title, svg.firstChild);
};
return svg;
}" aria-hidden="true" focusable="false" class="size-5.5"></svg></span> <span>Filter:</span></div>
}" aria-hidden="true" focusable="false" class="size-5"></svg></span> <span>Filter:</span></div>
<item-filter-stub filterlabel="Groups" items="undefined" filtername="groups" optionfilterlabel="Filter groups" showoptionfilter="true" allowmultiple="true" idattribute="id" displaynameattribute="displayName" filterableattributes="displayName" closeonclick="false" class="mr-2"></item-filter-stub>
<item-filter-stub filterlabel="Roles" items="[object Object],[object Object],[object Object],[object Object]" filtername="roles" optionfilterlabel="Filter roles" showoptionfilter="true" allowmultiple="true" idattribute="id" displaynameattribute="displayName" filterableattributes="displayName" closeonclick="false"></item-filter-stub>
</div>
Expand Down Expand Up @@ -135,15 +135,15 @@ exports[`Users view > list view > renders list initially 1`] = `
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle oc-td oc-table-data-cell oc-table-data-cell-displayName mark-element">Admin</td>
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle oc-td oc-table-data-cell oc-table-data-cell-mail">admin@example.org</td>
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle oc-td oc-table-data-cell oc-table-data-cell-role">Admin</td>
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle oc-td oc-table-data-cell oc-table-data-cell-accountEnabled"><span class="flex items-center"><span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5.5 mr-2"><svg data-testid="inline-svg-stub" src="icons/play-circle-line.svg" transform-source="(svg) => {
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-left align-middle oc-td oc-table-data-cell oc-table-data-cell-accountEnabled"><span class="flex items-center"><span class="oc-icon box-content inline-block align-baseline [&amp;_svg]:block size-5 mr-2"><svg data-testid="inline-svg-stub" src="icons/play-circle-line.svg" transform-source="(svg) => {
if (__props.accessibleLabel !== &quot;&quot;) {
const title = document.createElement(&quot;title&quot;);
title.setAttribute(&quot;id&quot;, svgTitleId.value);
title.appendChild(document.createTextNode(__props.accessibleLabel));
svg.insertBefore(title, svg.firstChild);
};
return svg;
}" aria-hidden="true" focusable="false" class="size-5.5"></svg></span><span>Allowed</span></span></td>
}" aria-hidden="true" focusable="false" class="size-5"></svg></span><span>Allowed</span></span></td>
<td data-v-27e13406="" data-v-3c9ab66c="" class="oc-table-cell text-right align-middle oc-td oc-table-data-cell oc-table-data-cell-actions pr-4">
<oc-button-stub arialabel="Show details" appearance="raw" colorrole="secondary" disabled="false" gapsize="medium" justifycontent="center" showspinner="false" size="medium" submit="button" type="button" nohover="false" class="ml-1 quick-action-button p-1 users-table-btn-details"></oc-button-stub>
<oc-button-stub arialabel="Edit" appearance="raw" colorrole="secondary" disabled="false" gapsize="medium" justifycontent="center" showspinner="false" size="medium" submit="button" type="button" nohover="false" class="ml-1 quick-action-button p-1 users-table-btn-edit"></oc-button-stub>
Expand Down
2 changes: 1 addition & 1 deletion packages/web-app-files/src/components/SideBar/Shares/Collaborators/RoleDropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
@click="selectRole(role)"
>
<span class="flex items-center">
<oc-icon :name="role.icon" class="pl-2 pr-4" />
<oc-icon :name="role.icon" class="pl-2 pr-4" fill-type="line" />
<role-item :role="role" />
</span>
<span class="flex">
Expand Down
Loading